Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(supabase): filter array column by array (ina and nina operators) #5922

Merged
merged 13 commits into from
May 24, 2024
Merged

feat(supabase): filter array column by array (ina and nina operators) #5922

merged 13 commits into from
May 24, 2024

Conversation

issa012
Copy link
Contributor

@issa012 issa012 commented May 6, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

No ina and nina

What is the new behavior?

Now it is possible to filter using ina and nina CRUD operators in supabase data provider. It allows for filtering array columns by matching all values inside array.
fixes #5902

Notes for reviewers

@issa012 issa012 requested a review from a team as a code owner May 6, 2024 13:21
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 84bf034

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/core Minor
@refinedev/supabase Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 6, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bdd99ee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 60 targets

Sent with 💌 from NxCloud.

@issa012 issa012 changed the title Iss5902 [FEAT]: Supabase Data Provider should filter array column by array May 6, 2024
@BatuhanW BatuhanW added this to the June Release milestone May 6, 2024
@netlify Netlify
Copy link

netlify bot commented May 9, 2024 •
edited
Loading

✅ Deploy Preview for refine-video-club ready!

Name Link
🔨 Latest commit 095e45f
🔍 Latest deploy log https://app.netlify.com/sites/refine-video-club/deploys/663c6d300e5394000829c11a
😎 Deploy Preview https://deploy-preview-5922--refine-video-club.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alicanerdurmaz
Copy link
Member

alicanerdurmaz commented May 9, 2024 •
edited
Loading

Hello, @issa012. Thanks for the PR 🚀

As you can see, the CI is failing but this is not related to the changes you made. First, I will solve this problem in another PR and then we will review your PR.

@aliemir
Copy link
Member

aliemir commented May 10, 2024

Failing CI will be resolved after #5937 is merged.

@aliemir aliemir changed the title [FEAT]: Supabase Data Provider should filter array column by array feat(supabase): filter array column by array (ina and nina operators) May 13, 2024
@aliemir aliemir changed the base branch from master to releases/june May 13, 2024 17:47
alicanerdurmaz
alicanerdurmaz requested changes May 16, 2024
View reviewed changes
packages/supabase/src/utils/generateFilter.ts Outdated Show resolved Hide resolved
packages/supabase/test/getList/index.mock.ts Outdated Show resolved Hide resolved
packages/supabase/test/getList/index.spec.ts Outdated Show resolved Hide resolved
packages/supabase/test/getList/index.spec.ts Outdated Show resolved Hide resolved
@alicanerdurmaz
Copy link
Member

@issa012 Hello again, will you be able to find time to continue with the PR?

@issa012
Copy link
Contributor Author

issa012 commented May 23, 2024

@alicanerdurmaz Hello. Yes I will complete it today

@issa012
Copy link
Contributor Author

issa012 commented May 23, 2024

After pnpm install every package was installed and built, is this normal behavior now?

@issa012
Copy link
Contributor Author

issa012 commented May 23, 2024

Also, there are other filters in supabase, that seem to be missing. If you open an issue with descriptions, I could implement them too.

@alicanerdurmaz
Copy link
Member

Also, there are other filters in supabase, that seem to be missing. If you open an issue with descriptions, I could implement them too.

Thanks, I will look into that! But, If you want, you can open an issue too.

@aliemir
Copy link
Member

aliemir commented May 24, 2024

After pnpm install every package was installed and built, is this normal behavior now?

Hey @issa012, this is the expected default behavior with our pnpm monorepo setup. Check out our Contributing Guide you can ignore these builds by passing --ignore-scripts 🚀

aliemir
aliemir approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@aliemir aliemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aliemir aliemir merged commit c4b8761 into refinedev:releases/june May 24, 2024
15 checks passed
@aliemir aliemir mentioned this pull request May 24, 2024
Merged
BatuhanW added a commit that referenced this pull request Jun 4, 2024
@issa012 @alicanerdurmaz
@aliemir @BatuhanW
feat(supabase): filter array column by array (ina and nina operat…
a39f195 
…ors) (#5922)

Co-authored-by: Alican Erdurmaz <alicanerdurmaz@gmail.com>
Co-authored-by: Ali Emir Şen <senaliemir@gmail.com>
Co-authored-by: Batuhan Wilhelm <batuhanwilhelm@gmail.com>
@jim-knight jim-knight mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicanerdurmaz alicanerdurmaz alicanerdurmaz approved these changes

@aliemir aliemir aliemir approved these changes

@BatuhanW BatuhanW Awaiting requested review from BatuhanW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
June Release
Development

Successfully merging this pull request may close these issues.

[FEAT]: Supabase Data Provider should filter array column by array
4 participants
@issa012 @alicanerdurmaz @aliemir @BatuhanW